Author Topic: 1.2.2.x  (Read 26611 times)

zero

  • Full Member
  • ***
  • Posts: 194
    • View Profile
    • IBIS Gaming
    • Email
Re: 1.2.2.x
« Reply #50 on: July 27, 2011, 06:17:38 PM »
Thank you  ;D

zero

  • Full Member
  • ***
  • Posts: 194
    • View Profile
    • IBIS Gaming
    • Email
Re: 1.2.2.x
« Reply #51 on: July 27, 2011, 09:30:25 PM »
I noticed that in the update logs you did this:
Quote
added giving XP for touching hostages and losing xp for killing one

However I can not find any cvar that controls this. I do not want to reward any xp for this or take away xp.

In addition is there and or can there be a universal cvar that prevents xp from ever being taken away. I want to ensure that NOTHING, has the ability to reduce a users xp except for me editing the users xp directly.

Ownz

  • Developer
  • Administrator
  • Hero Member
  • *****
  • Posts: 2437
  • chmod -R 777 *
    • View Profile
    • OwnageClan
Re: 1.2.2.x
« Reply #52 on: July 27, 2011, 09:54:26 PM »
what are you trying to do?

fine control is provided via the event
   W3SetVar(EventArg1,awardedfromevent); //set event vars
      W3SetVar(EventArg2,xp);
      W3SetVar(EventArg3,gold);
      W3CreateEvent(OnPreGiveXPGold,client); //fire event
      

zero

  • Full Member
  • ***
  • Posts: 194
    • View Profile
    • IBIS Gaming
    • Email
Re: 1.2.2.x
« Reply #53 on: July 27, 2011, 10:04:41 PM »
Basically I wanted to prevent War3Source_HostageFollow and War3Source_HostageKilled from doing anything so for now I have just commented them out and recompiled. Other users may want a simple way to disable those or a way to individually adjust the xp awarded by them using cvars like how the rest of the xp rewards are handled.

Just to make sure there is not anything else other than War3Source_HostageKilled that can automatically remove players xp? This is why I am requesting a universal cvar to ensure that any stock setting that removes xp is permanently disabled. This way you can add new features without less experienced admins worrying about some new setting suddenly taking users xp away.

BTW it appears that there was quite a few instances of
Code: [Select]
new race=War3_GetRace(i) in War3Source_Engine_XPGoldCS so I commented those out as well. You may want to brush over that file to clean out any old or not needed code before final release of this beta.

Great work as always, I am looking forward to finishing up some custom work on my end and getting my servers updated to the latest versions.

Ownz

  • Developer
  • Administrator
  • Hero Member
  • *****
  • Posts: 2437
  • chmod -R 777 *
    • View Profile
    • OwnageClan
Re: 1.2.2.x
« Reply #54 on: July 27, 2011, 10:19:23 PM »
as always, you are urged to contribute to the SVN if you can.

zero

  • Full Member
  • ***
  • Posts: 194
    • View Profile
    • IBIS Gaming
    • Email
Re: 1.2.2.x
« Reply #55 on: July 27, 2011, 10:36:34 PM »
as always, you are urged to contribute to the SVN if you can.

I will see if I can throw in some convars when I get a chance. Where to I send the altered file?

Ownz

  • Developer
  • Administrator
  • Hero Member
  • *****
  • Posts: 2437
  • chmod -R 777 *
    • View Profile
    • OwnageClan
Re: 1.2.2.x
« Reply #56 on: July 28, 2011, 07:35:13 AM »
follow the svn tutorial
ownageclan.com/wiki

zero

  • Full Member
  • ***
  • Posts: 194
    • View Profile
    • IBIS Gaming
    • Email
Re: 1.2.2.x
« Reply #57 on: July 28, 2011, 03:07:23 PM »
I can confirm that you LOSE xp for making kills and I can see where this is coming from, I just got to find the actual line in the code...

If YOU as level 2 kill a player at lets say level 30 you get lets say 150xp

If they kill you they lose around 150xp

Basically the function is written as (30-2)x=xp so when it goes (2-30)x=xp you go negative...

To fix the problem open Engine_XPGold and change the contents of GiveKillXPCreds to:

Code: [Select]
GiveKillXPCreds(client,playerkilled,bool:headshot,bool:melee)
{
//PrintToChatAll("1");
new race=War3_GetRace(client);
if(race>0){
new killerlevel=War3_GetLevel(client,War3_GetRace(client));
new victimlevel=War3_GetLevel(playerkilled,War3_GetRace(playerkilled));
new leveldiff;

leveldiff=victimlevel-killerlevel;

//check for negitive and assign to 0 so no bonus is awarded
if(leveldiff<0)
{
leveldiff=0;
}

new killxp=W3GetKillXP(client,leveldiff);

new addxp=killxp;
if(headshot) addxp+=((killxp*GetConVarInt(HeadshotXPCvar))/100);
if(melee) addxp+=((killxp*GetConVarInt(MeleeXPCvar))/100);



new String:killaward[64];
Format(killaward,sizeof(killaward),"%T","a kill",client);
W3GiveXPGold(client,XPAwardByKill,addxp,W3GetKillGold(),killaward);
}
}

The above will ensure that no xp is ever removed and that if you kill a player lower level than yourself you get no bonus. In theory you could make your own function here to reward some functional less xp without going negative if you wanted some addational customization.
« Last Edit: July 28, 2011, 03:19:28 PM by zero »

Ownz

  • Developer
  • Administrator
  • Hero Member
  • *****
  • Posts: 2437
  • chmod -R 777 *
    • View Profile
    • OwnageClan
Re: 1.2.2.x
« Reply #58 on: July 28, 2011, 03:26:52 PM »
better fix is in W3GetKillXP

Code: [Select]
public NW3GetKillXP(Handle:plugin,numParams)
{
new client=GetNativeCell(1);
new race=War3_GetRace(client);
if(race>0){
new level=War3_GetLevel(client,race);
if(level>MAXLEVELXPDEFINED)
level=MAXLEVELXPDEFINED;
new leveldiff= GetNativeCell(2);

if(leveldiff<0) leveldiff=0;

return (IsShortTerm()?XPShortTermKillXP[level] :XPLongTermKillXP[level]) + (GetConVarInt(hLevelDifferenceBounus)*leveldiff);
}
return 0;
}

committed to svn

Schmarotzer

  • Full Member
  • ***
  • Posts: 189
  • Ich schmarotze dich!
    • ICQ Messenger - 258631507
    • View Profile
    • Russian Fan-Site for german folk-rock-metal band Schandmaul
Re: 1.2.2.x
« Reply #59 on: August 01, 2011, 03:41:09 AM »
Fixed Scout-Race for multilanguage some strings and translated to RU
Welcome to my server

Ownz

  • Developer
  • Administrator
  • Hero Member
  • *****
  • Posts: 2437
  • chmod -R 777 *
    • View Profile
    • OwnageClan
Re: 1.2.2.x
« Reply #60 on: August 01, 2011, 07:06:54 AM »
why not SVN?

got some minor error here
COPY ENTIRE URL
http://ownageclan.com/websvn/comp.php?repname=war3source&compare[]=/@426&compare[]=/@427
« Last Edit: August 01, 2011, 07:11:29 AM by Ownz »

Schmarotzer

  • Full Member
  • ***
  • Posts: 189
  • Ich schmarotze dich!
    • ICQ Messenger - 258631507
    • View Profile
    • Russian Fan-Site for german folk-rock-metal band Schandmaul
Re: 1.2.2.x
« Reply #61 on: August 01, 2011, 09:15:55 PM »
Simply now I have no svn available (reinstalled windows)
and I translated it when I was on work ^__^
Welcome to my server

Schmarotzer

  • Full Member
  • ***
  • Posts: 189
  • Ich schmarotze dich!
    • ICQ Messenger - 258631507
    • View Profile
    • Russian Fan-Site for german folk-rock-metal band Schandmaul
Re: 1.2.2.x
« Reply #62 on: August 02, 2011, 12:29:03 AM »
I put the finishing touches in Russian Translation

Полностью перевел на русский все новые фразы и файлы.
Welcome to my server

ItsMev

  • Newbie
  • *
  • Posts: 40
    • View Profile
Re: 1.2.2.x
« Reply #63 on: August 03, 2011, 11:04:34 PM »
L 08/04/2011 - 14:59:07: [W3E] ERROR, HELPER FUNCTION FROM EXTENSION HELPER PLUGIN NOT REGISTERED
L 08/04/2011 - 14:59:07: [W3E] ERROR, HELPER FUNCTION FROM EXTENSION HELPER PLUGIN NOT REGISTERED
L 08/04/2011 - 14:59:07: [W3E] ERROR, HELPER FUNCTION FROM EXTENSION HELPER PLUGIN NOT REGISTERED
L 08/04/2011 - 14:59:07: [W3E] ERROR, HELPER FUNCTION FROM EXTENSION HELPER PLUGIN NOT REGISTERED
L 08/04/2011 - 14:59:07: [W3E] ERROR, HELPER FUNCTION FROM EXTENSION HELPER PLUGIN NOT REGISTERED
L 08/04/2011 - 14:59:07: [W3E] ERROR, HELPER FUNCTION FROM EXTENSION HELPER PLUGIN NOT REGISTERED
L 08/04/2011 - 14:59:07: [W3E] ERROR, HELPER FUNCTION FROM EXTENSION HELPER PLUGIN NOT REGISTERED
L 08/04/2011 - 14:59:07: [W3E] ERROR, HELPER FUNCTION FROM EXTENSION HELPER PLUGIN NOT REGISTERED
L 08/04/2011 - 14:59:07: [W3E] ERROR, HELPER FUNCTION FROM EXTENSION HELPER PLUGIN NOT REGISTERED
L 08/04/2011 - 14:59:07: [W3E] ERROR, HELPER FUNCTION FROM EXTENSION HELPER PLUGIN NOT REGISTERED
pure virtual method called
terminate called without an active exception
PreMinidumpCallback: updating dump comment
Uploading dump (in-process) [proxy '']
/tmp/dumps/crash_20110804145907_1.dmp
framefunction.cpp (120) : Assertion Failed: CFrameFunctionMgr::~CFrameFunctionMgr: non static FrameFunction still registered
/home/VALVE/rackadmin/buildslave/steam_rel_client_linux/build/src/common/framefunction.cpp 120 Assertion Failed: CFrameFunctionMgr::~CFrameFunctionMgr: non static FrameFunction still registered
./srcds_run: line 372: 31914 Segmentation fault      $HL_CMD

O_O?

Ownz

  • Developer
  • Administrator
  • Hero Member
  • *****
  • Posts: 2437
  • chmod -R 777 *
    • View Profile
    • OwnageClan
Re: 1.2.2.x
« Reply #64 on: August 03, 2011, 11:06:46 PM »
War3Source_Extension_Helper.smx loaded?

ItsMev

  • Newbie
  • *
  • Posts: 40
    • View Profile
Re: 1.2.2.x
« Reply #65 on: August 04, 2011, 12:09:56 AM »
Can't figure out how to get most of my races to compile with newest version :p

W3PrintSkillDmgHintConsole( victim, attacker, War3_GetWar3DamageDealt(),);
Whats that supposed to be changed to O_o

Ownz

  • Developer
  • Administrator
  • Hero Member
  • *****
  • Posts: 2437
  • chmod -R 777 *
    • View Profile
    • OwnageClan
Re: 1.2.2.x
« Reply #66 on: August 04, 2011, 07:36:33 AM »
see first post

ItsMev

  • Newbie
  • *
  • Posts: 40
    • View Profile
Re: 1.2.2.x
« Reply #67 on: August 05, 2011, 05:21:17 AM »
Sorry yeah I figured that out like..right after I posted, having some crash issues now.

Installed newst version and getting all this

L 08/05/2011 - 21:16:37: [war3source/War3Source_Engine_DamageSystem.smx] war3source/War3Source_000_Footman.smx
L 08/05/2011 - 21:16:50: [war3source/War3Source_Engine_DamageSystem.smx] You may not set damage mod percent here, use ....Pre forward
L 08/05/2011 - 21:16:50: [war3source/War3Source_Engine_DamageSystem.smx] war3source/War3Source_000_Footman.smx
L 08/05/2011 - 21:18:14: [war3source/War3Source_Engine_DamageSystem.smx] You may not set damage mod percent here, use ....Pre forward
L 08/05/2011 - 21:18:14: [war3source/War3Source_Engine_DamageSystem.smx] war3source/War3Source_CustomRace_LuckyStrike.smx

for lots of races, what is wrong with War3DealDamge?
« Last Edit: August 05, 2011, 05:41:31 AM by ItsMev »

ItsMev

  • Newbie
  • *
  • Posts: 40
    • View Profile
Re: 1.2.2.x
« Reply #68 on: August 05, 2011, 06:10:33 AM »
Also;

L 08/05/2011 - 16:33:11: [SM] Plugin encountered error 15: Array index is out of bounds
L 08/05/2011 - 16:33:11: [SM] Native "War3_GetRaceSkillCount" reported: bad race ID 0
L 08/05/2011 - 16:33:11: [SM] Displaying call stack trace for plugin "war3source/War3Source_Engine_XPGold.smx":
L 08/05/2011 - 16:33:11: [SM]   
  •   Line 901, War3Source_Engine_XPGold.sp::LevelCheck()

L 08/05/2011 - 16:33:11: [SM]   [1]  Line 886, War3Source_Engine_XPGold.sp::OnWar3Event()

Ownz

  • Developer
  • Administrator
  • Hero Member
  • *****
  • Posts: 2437
  • chmod -R 777 *
    • View Profile
    • OwnageClan
Re: 1.2.2.x
« Reply #69 on: August 05, 2011, 07:41:48 AM »
your races are not following damage modification guidelines
War3_DamageModPercent( can only be used under OnW3TakeDmgBulletPre( or OnW3TakeDmgAllPre(
War3_DeadDamage can only be used under the non Pre forward.


bad race ID 0 for that instance fixed on SVN

ItsMev

  • Newbie
  • *
  • Posts: 40
    • View Profile
Re: 1.2.2.x
« Reply #70 on: August 08, 2011, 04:34:14 AM »
L 08/08/2011 - 14:41:14: [SM] Displaying call stack trace for plugin "war3source/War3Source_Engine_Weapon.smx":
L 08/08/2011 - 14:41:14: [SM]   
  •   Line 312, War3Source_Engine_Weapon.sp::OnPlayerRunCmd()

L 08/08/2011 - 14:42:25: [SM] Native "SetEntPropFloat" reported: Entity -1 (-1) is invalid
L 08/08/2011 - 14:42:25: [SM] Displaying call stack trace for plugin "war3source/War3Source_Engine_Weapon.smx":
L 08/08/2011 - 14:42:25: [SM]   
  •   Line 312, War3Source_Engine_Weapon.sp::OnPlayerRunCmd()


Noticed this in logs, any ideas?

Ownz

  • Developer
  • Administrator
  • Hero Member
  • *****
  • Posts: 2437
  • chmod -R 777 *
    • View Profile
    • OwnageClan
Re: 1.2.2.x
« Reply #71 on: August 08, 2011, 07:54:56 AM »
just ignore it for now

Schmarotzer

  • Full Member
  • ***
  • Posts: 189
  • Ich schmarotze dich!
    • ICQ Messenger - 258631507
    • View Profile
    • Russian Fan-Site for german folk-rock-metal band Schandmaul
Re: 1.2.2.x
« Reply #72 on: August 08, 2011, 10:44:58 PM »
Dark Elf only for TF2?
Welcome to my server

Ownz

  • Developer
  • Administrator
  • Hero Member
  • *****
  • Posts: 2437
  • chmod -R 777 *
    • View Profile
    • OwnageClan
Re: 1.2.2.x
« Reply #73 on: August 08, 2011, 10:46:58 PM »
are you updating the translations? because the translation files are not there so i cant test it on css

Schmarotzer

  • Full Member
  • ***
  • Posts: 189
  • Ich schmarotze dich!
    • ICQ Messenger - 258631507
    • View Profile
    • Russian Fan-Site for german folk-rock-metal band Schandmaul
Re: 1.2.2.x
« Reply #74 on: August 09, 2011, 01:28:47 AM »
yup )

OMG
Quote
LoadTranslations("w3s.race.scout_o.phrases");
LoadTranslations("w3s.race.darkelf_o.phrases");

My mistake
Sorry ))
« Last Edit: August 09, 2011, 01:31:38 AM by Schmarotzer »
Welcome to my server