Author Topic: [old topic] Succubus Hunter  (Read 26061 times)

Adluc

  • Newbie
  • *
  • Posts: 9
    • View Profile
Re: Succubus Hunter
« Reply #25 on: June 29, 2010, 12:57:06 PM »
Code: [Select]
L 06/29/2010 - 20:55:14: [SM] Unable to load plugin "war3source/War3Source_SuccubusHunter.smx": Native "War3_SetMaxSpeed" was not found

Whats wrong ?
« Last Edit: June 29, 2010, 01:47:51 PM by Adluc »

Naris

  • Jr. Member
  • **
  • Posts: 58
    • View Profile
    • Email
Re: Succubus Hunter
« Reply #26 on: June 29, 2010, 09:01:25 PM »
Code: [Select]
L 06/29/2010 - 20:55:14: [SM] Unable to load plugin "war3source/War3Source_SuccubusHunter.smx": Native "War3_SetMaxSpeed" was not found

Whats wrong ?

Version War3Source 1.1.1 radically changed how speeed, gravity and visibility are set, which broke this race

kore

  • Newbie
  • *
  • Posts: 2
    • View Profile
    • Email
Re: Succubus Hunter
« Reply #27 on: June 30, 2010, 05:38:38 AM »
Not work at new SM 1.3.3 and new CSS OB engine.

Using Linux Debian.

Ownz

  • Developer
  • Administrator
  • Hero Member
  • *****
  • Posts: 2437
  • chmod -R 777 *
    • View Profile
    • OwnageClan
Re: Succubus Hunter
« Reply #28 on: June 30, 2010, 08:04:28 AM »
author is no longer active, how many people are using this race?

James

  • Newbie
  • *
  • Posts: 18
    • View Profile
    • SurfLords
    • Email
Re: Succubus Hunter
« Reply #29 on: July 01, 2010, 12:22:55 AM »
L 06/30/2010 - 21:57:47: [SM] Plugin "War3Source_SuccubusHunter.smx" encountered error 23: Native detected error
L 06/30/2010 - 21:57:47: [SM] Invalid timer handle 49350436 (error 3) during timer end, displayed function is timer callback, not the stack trace
L 06/30/2010 - 21:57:47: [SM] Unable to call function "FinishTrans" due to above error(s).
L 06/30/2010 - 21:58:51: [SM] Plugin "War3Source_SuccubusHunter.smx" encountered error 23: Native detected error
L 06/30/2010 - 21:58:51: [SM] Invalid timer handle 4d1903f6 (error 3) during timer end, displayed function is timer callback, not the stack trace
L 06/30/2010 - 21:58:51: [SM] Unable to call function "FinishTrans" due to above error(s).
L 06/30/2010 - 21:59:44: [SM] Plugin "War3Source_SuccubusHunter.smx" encountered error 23: Native detected error
L 06/30/2010 - 21:59:44: [SM] Invalid timer handle 4f70044a (error 3) during timer end, displayed function is timer callback, not the stack trace
L 06/30/2010 - 21:59:44: [SM] Unable to call function "FinishTrans" due to above error(s).
L 06/30/2010 - 22:01:07: [SM] Plugin "War3Source_SuccubusHunter.smx" encountered error 23: Native detected error
L 06/30/2010 - 22:01:07: [SM] Invalid timer handle 529504c2 (error 3) during timer end, displayed function is timer callback, not the stack trace
L 06/30/2010 - 22:01:07: [SM] Unable to call function "FinishTrans" due to above error(s).
L 06/30/2010 - 22:02:52: [SM] Plugin "War3Source_SuccubusHunter.smx" encountered error 23: Native detected error
L 06/30/2010 - 22:02:52: [SM] Invalid timer handle 56ff04dc (error 3) during timer end, displayed function is timer callback, not the stack trace
L 06/30/2010 - 22:02:52: [SM] Unable to call function "FinishTrans" due to above error(s).
L 06/30/2010 - 22:04:55: [SM] Plugin "War3Source_SuccubusHunter.smx" encountered error 23: Native detected error
L 06/30/2010 - 22:04:55: [SM] Invalid timer handle 5d0e0434 (error 3) during timer end, displayed function is timer callback, not the stack trace
L 06/30/2010 - 22:04:55: [SM] Unable to call function "FinishTrans" due to above error(s).
L 06/30/2010 - 22:05:37: [SM] Plugin "War3Source_SuccubusHunter.smx" encountered error 23: Native detected error
L 06/30/2010 - 22:05:37: [SM] Invalid timer handle 5e8b0391 (error 3) during timer end, displayed function is timer callback, not the stack trace
L 06/30/2010 - 22:05:37: [SM] Unable to call function "FinishTrans" due to above error(s).

[Oddity]TeacherCreature

  • Sr. Member
  • ****
  • Posts: 467
    • View Profile
Re: Succubus Hunter
« Reply #30 on: July 05, 2010, 12:07:24 PM »
Ok with the new releases this race does not compile

there are two commands/functions missing

War3_setmaxspeed
and
War3_mingravity

unrecognized not sure if they need to be called first or if they have been changed..
It kind of looked like you used something called War3_Setbuff I think but I dont know the syntax and I was alzy to look in case it was wrong

Can u tell me how to call those or give me new command with syntax and I will go fix it so you dont have to worry about it  (i like working on races)

[Oddity]TeacherCreature

  • Sr. Member
  • ****
  • Posts: 467
    • View Profile
Re: Succubus Hunter
« Reply #31 on: July 05, 2010, 12:50:34 PM »
Ok found in Natives thanks Stinky!

This Succubus should work testing it all now:



Naris

  • Jr. Member
  • **
  • Posts: 58
    • View Profile
    • Email
Re: Succubus Hunter
« Reply #32 on: July 06, 2010, 11:47:27 AM »
I have merged my adaptations for TF2 along with several fixes to the Succubus Hunter Race (including updating to the latest War3Source API).

Among the changes I have made are:
-Changed to respect immunity
-Gives credits instead of money for mods other than cstrike
-Checks for headshots when handling player_death instead of player_hurt (that doesn't have that flag)
-Added "skulls" chat command to display number of skulls you have.
-Fixed OnClientDisconnect() / skulls carrying over to the next client
-Capped the amount of XP gained when a Succubus Hunter spawns with Totem Incantation to no more than that gained by a kill.
-Adapted Assault Tackle and other things for TF2 as well as CStrike
-Always give skulls when a Succubus Hunter kills with Head Hunter and/or Daemonic Knife
« Last Edit: July 06, 2010, 12:02:49 PM by Naris »

Naris

  • Jr. Member
  • **
  • Posts: 58
    • View Profile
    • Email
Re: Succubus Hunter
« Reply #33 on: July 10, 2010, 11:14:52 AM »
I have updated the succubus Hunter race to use the new War3Source 1.1.2 API to create the race.

Ownz

  • Developer
  • Administrator
  • Hero Member
  • *****
  • Posts: 2437
  • chmod -R 777 *
    • View Profile
    • OwnageClan
Re: Succubus Hunter
« Reply #34 on: July 10, 2010, 05:30:14 PM »
Code: [Select]
public Action:FinishTrans(Handle:timer,any:userid)
{
    new client=GetClientOfUserId(userid);
    if (client>0)
    {
        m_IsTransformed[client]=false;
        War3_SetBuff(client,fMaxSpeed,raceID,1.0);
        War3_SetBuff(client,fLowGravitySkill,raceID,1.0);
        PrintToChat(client,"\x04[Daemonic Transformation] \x01You transformed back to normal again.");
    }
}

TO PASS THE CLIENT
Code: [Select]
public Action:FinishTrans(Handle:timer,any:client)
{
  
        m_IsTransformed[client]=false;
        War3_SetBuff(client,fMaxSpeed,raceID,1.0);
        War3_SetBuff(client,fLowGravitySkill,raceID,1.0);
      if(War3_ValidPlayer(client)){
        PrintToChat(client,"\x04[Daemonic Transformation] \x01You transformed back to normal again.");
}
}
    
}
BUFF needs to be removed whether client is valid or not, otherwise the next client gets free speed boost etc

you need to pass the client directly instead of userid, if client disconnects player is useless and we don't know what "client" is anymore and buffs wont be canceled
Code: [Select]
CreateTimer(10.0,FinishTrans,client);
we only need to check for valid client when printing the message

Ownz

  • Developer
  • Administrator
  • Hero Member
  • *****
  • Posts: 2437
  • chmod -R 777 *
    • View Profile
    • OwnageClan
Re: Succubus Hunter
« Reply #35 on: July 10, 2010, 05:59:21 PM »
succubs doesnt always jump in the direction you are aiming, it looks like it uses a different mechanism. it should jump in the direction the player is aiming

the TF_ beam follow should be lower because the beam blocks the player's view screen due to lag from the server, we need to make it somehow lower

skill descriptions need to be a bit more detailed and its jump further not higher

Ownz

  • Developer
  • Administrator
  • Hero Member
  • *****
  • Posts: 2437
  • chmod -R 777 *
    • View Profile
    • OwnageClan
Re: Succubus Hunter
« Reply #36 on: July 13, 2010, 08:35:42 AM »
whos officially working on this race cuz this race has alot of bugs

iceman

  • Full Member
  • ***
  • Posts: 220
    • View Profile
Re: Succubus Hunter
« Reply #37 on: July 13, 2010, 05:04:33 PM »
I,m running the one naris posted,Is that the one u tried? Speed carries over to the other races among other things.

Ownz

  • Developer
  • Administrator
  • Hero Member
  • *****
  • Posts: 2437
  • chmod -R 777 *
    • View Profile
    • OwnageClan
Re: Succubus Hunter
« Reply #38 on: July 13, 2010, 05:36:27 PM »
Naris version, yea the ultimate doesn't cancel

Naris

  • Jr. Member
  • **
  • Posts: 58
    • View Profile
    • Email
Re: Succubus Hunter
« Reply #39 on: July 13, 2010, 06:29:18 PM »
Naris version, yea the ultimate doesn't cancel

I didn't alter the ultimate from the original code other that to update it to the new API. I'll look into that.
« Last Edit: July 13, 2010, 06:38:09 PM by Naris »

Naris

  • Jr. Member
  • **
  • Posts: 58
    • View Profile
    • Email
Re: Succubus Hunter
« Reply #40 on: July 13, 2010, 06:36:09 PM »
Code: [Select]
public Action:FinishTrans(Handle:timer,any:userid)
{
    new client=GetClientOfUserId(userid);
    if (client>0)
    {
        m_IsTransformed[client]=false;
        War3_SetBuff(client,fMaxSpeed,raceID,1.0);
        War3_SetBuff(client,fLowGravitySkill,raceID,1.0);
        PrintToChat(client,"\x04[Daemonic Transformation] \x01You transformed back to normal again.");
    }
}

TO PASS THE CLIENT
Code: [Select]
public Action:FinishTrans(Handle:timer,any:client)
{
  
        m_IsTransformed[client]=false;
        War3_SetBuff(client,fMaxSpeed,raceID,1.0);
        War3_SetBuff(client,fLowGravitySkill,raceID,1.0);
      if(War3_ValidPlayer(client)){
        PrintToChat(client,"\x04[Daemonic Transformation] \x01You transformed back to normal again.");
}
}
    
}
BUFF needs to be removed whether client is valid or not, otherwise the next client gets free speed boost etc

you need to pass the client directly instead of userid, if client disconnects player is useless and we don't know what "client" is anymore and buffs wont be canceled
Code: [Select]
CreateTimer(10.0,FinishTrans,client);
we only need to check for valid client when printing the message

Chinging the client instead of the userid is a really bad solution to the issue of "buffs" not getting reset. The next client will still get a free speed boost, etc until the timer goes off.

A much better solution is to use the userid in the timer and to reset the "buffs" and anything else OnPlayerDisconnect() (and death).

Ownz

  • Developer
  • Administrator
  • Hero Member
  • *****
  • Posts: 2437
  • chmod -R 777 *
    • View Profile
    • OwnageClan
Re: Succubus Hunter
« Reply #41 on: July 13, 2010, 06:39:48 PM »
1 you can pass the client
2 you can cancel buff on death and disconnect

which one is easier?

the next client wont connect in 10 seconds....even if it does the timer kills the buff


-----also long jump doesnt always jump where you aim

Naris

  • Jr. Member
  • **
  • Posts: 58
    • View Profile
    • Email
Re: Succubus Hunter
« Reply #42 on: July 13, 2010, 06:40:56 PM »
succubs doesnt always jump in the direction you are aiming, it looks like it uses a different mechanism. it should jump in the direction the player is aiming

the TF_ beam follow should be lower because the beam blocks the player's view screen due to lag from the server, we need to make it somehow lower

skill descriptions need to be a bit more detailed and its jump further not higher

Is that in cstrike of TF2?

I added the TF2 code, I left the cstrike code alone since I have no way of testing it...

Ownz

  • Developer
  • Administrator
  • Hero Member
  • *****
  • Posts: 2437
  • chmod -R 777 *
    • View Profile
    • OwnageClan
Re: Succubus Hunter
« Reply #43 on: July 13, 2010, 06:47:32 PM »
doesnt always jump in the aimed direction in tf2, idk about css

code is quite bloated and contains sourcecraft sections. if there are enough requests i can write this race from scratch

Naris

  • Jr. Member
  • **
  • Posts: 58
    • View Profile
    • Email
Re: Succubus Hunter
« Reply #44 on: July 13, 2010, 06:49:50 PM »
1 you can pass the client
2 you can cancel buff on death and disconnect

which one is easier?

the next client wont connect in 10 seconds....even if it does the timer kills the buff


-----also long jump doesnt always jump where you aim

Your suggestion is just really sloppy, lazy code and is a really, really bad solution.
It is not difficult at all to write proper code to handle things properly.

I would never, ever allow such sloppy coding into production where I work.
« Last Edit: July 13, 2010, 06:51:47 PM by Naris »

Ownz

  • Developer
  • Administrator
  • Hero Member
  • *****
  • Posts: 2437
  • chmod -R 777 *
    • View Profile
    • OwnageClan
Re: Succubus Hunter
« Reply #45 on: July 13, 2010, 06:51:54 PM »
the simpler it is, the less chance it will error and easier to debug.

for example, many races only deal with resetting things at spawn and timers, or by GetGameTime(), for that reason i decided not to implement round start event as races shouldn't deal with such an event and use spawn - OnWar3EventSpawn instead

Naris

  • Jr. Member
  • **
  • Posts: 58
    • View Profile
    • Email
Re: Succubus Hunter
« Reply #46 on: July 13, 2010, 07:01:46 PM »
doesnt always jump in the aimed direction in tf2, idk about css

It jumps in the direction you are traveling, not the direction you are aiming.
That is what the original implementation from the original author does.

That is not a bug.

Ownz

  • Developer
  • Administrator
  • Hero Member
  • *****
  • Posts: 2437
  • chmod -R 777 *
    • View Profile
    • OwnageClan
Re: Succubus Hunter
« Reply #47 on: July 13, 2010, 07:02:40 PM »
is that what BaseVelocity is? thats cool

Naris

  • Jr. Member
  • **
  • Posts: 58
    • View Profile
    • Email
Re: Succubus Hunter
« Reply #48 on: July 13, 2010, 07:38:39 PM »
I have always used m_vecVelocity[0], which is the entities velocity vector, as you would set in the last parameter of TeleportEntity().

m_vecBaseVelocity must be pretty much the same thing.

Naris

  • Jr. Member
  • **
  • Posts: 58
    • View Profile
    • Email
Re: Succubus Hunter
« Reply #49 on: July 13, 2010, 07:53:19 PM »
Here is a new version of Succubus Hunter that should fix the ultimate attributes persisting after  death and/or changing races.

« Last Edit: July 13, 2010, 07:56:00 PM by Naris »